Comparing changes

This change is a mechanical switch to change most of the code paths that assume TOAST value IDs to be Oids to become uint64, easing an upcoming change to allow 8-byte TOAST values. The areas touched are related to table AM, amcheck and logical decoding's reorder buffer. A good chunk of the changes involve switching printf() markers from %u to PRIu64.

This eases a follow-up change to support 8-byte TOAST value IDs, as the maximum chunk size allowed for a single chunk of TOASTed data depends on the size of the value ID.

…_OID This rename is in preparation of a follow-up commit that aims at adding support for multiple types of external on-disk TOAST pointers, where the OID type is only one subset of them.

This commit introduces a new interface for external TOAST pointers, which is able to make a translation of the varlena pointers stored on disk to/from an new in-memory structure called toast_external. The types of varatt_external supported on disk need to be registered into a new subsystem in a new file, called toast_external.[c|h], then define a set of callbacks to allow the toasting and detoasting code to use it. A follow-up change will rely on this refactoring to introduce new vartag_external values with an associated varatt_external_* that is able, which would be used in int8 TOAST tables.

This isolates most of the knowledge of varatt_external_oid into the local area where it is manipulated through the toast_external transition type, with the backend code not requiring it. Extension code should not need it either, as toast_external should be the layer to use when looking at external on-dist TOAST varlenas.

This callback is called by toast_save_datum() to retrieve a new value from a source related to the vartag_external we are dealing with. As of now, it is simply a wrapper around GetNewOidWithIndex() for the "OID" on-disk TOAST external pointer. This will be used later on by more external pointer types, like the int8 one. InvalidToastId is introduced to track the concept of an "invalid" TOAST value, required for toast_save_datum().

This is required to be able to do catalog cache lookups of int8 fields for toast values of the same type.

This GUC controls the data type used for newly-created TOAST values, with two modes supported: "oid" and "int8". This will be used by an upcoming patch.

An 8 byte counter is added to the control file, providing a unique 64-bit-wide source for toast value IDs, with the same guarantees as OIDs in terms of durability. SQL functions and tools looking at the control file are updated. A WAL record is generated every 8k values generated, that can be adjusted if required. Requires a bump of WAL format. Requires a bump of control file version. Requires a catalog version bump.

This is required for a follow-up patch that will add support for 8-byte TOAST values, with this function being changed so as it is able to support the largest TOAST value type available. XXX: Bump catalog version.

This commit adds the possibility to define TOAST tables with bigint as value ID, based on the GUC default_toast_type. All the external TOAST pointers still rely on varatt_external and a single vartag, with all the values inserted in the bigint TOAST tables fed from the existing OID value generator. This will be changed in an upcoming patch that adds more vartag_external types and its associated structures, with the code being able to use a different external TOAST pointer depending on the attribute type of chunk_id in TOAST relations. All the changes done here are mechanical, with all the TOAST code able to do chunk ID lookups based on the two types supported. XXX: Catalog version bump required.

This adds coverage for relations created with default_toast_type = 'int8', for external TOAST pointers both compressed and uncompressed.

This includes the possibility to perform binary upgrades with TOAST table types applied to a new cluster, relying on SET commands based on default_toast_type to apply one type of TOAST table or the other. Some tests are included, this is a pretty mechanical change. Dump format is bumped to 1.17 due to the addition of the TOAST table type in the custom format.

This is a new type of external TOAST pointer, able to be fed 8-byte TOAST values. It uses a dedicated vartag_external, which is used when a TOAST table uses bigint for its chunk_id. The relevant callbacks are added to toast_external.c.

This patch is a proof of concept to show what is required to change in the tests of pg_amcheck to be able to work with the new type of external TOAST pointer.

…e loop problem) This branch was automatically generated by a robot using patches from an email thread registered at: https://commitfest.postgresql.org/patch/5830 The branch will be overwritten each time a new patch version is posted to the thread, and also periodically to check for bitrot caused by changes on the master branch. Patch(es): https://www.postgresql.org/message-id/[email protected] Author(s): Michael Paquier

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Comparing changes

Open a pull request

Commits on Aug 9, 2025

This comparison is taking too long to generate.

Uh oh!