Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: postgresql-cfbot/postgresql
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: cf/5715~1
Choose a base ref
...
head repository: postgresql-cfbot/postgresql
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: cf/5715
Choose a head ref
  • 5 commits
  • 15 files changed
  • 2 contributors

Commits on Aug 9, 2025

  1. brin refactoring 

    For adding BRIN index support in amcheck we need some tiny changes in BRIN
core code:

* We need to have tuple descriptor for on-disk storage of BRIN tuples.
  It is a public field 'bd_disktdesc' in BrinDesc, but to access it we
  need function 'brtuple_disk_tupdesc' which is internal. This commit
  makes it extern and renames it to 'brin_tuple_tupdesc'.

* For meta page check we need to know pages_per_range upper limit. It's
  hardcoded now. This commit moves its value to macros BRIN_MAX_PAGES_PER_RANGE
  so that we can use it in amcheck too.
    @dvcer
    dvcer authored and Commitfest Bot committed Aug 9, 2025
    Configuration menu
    Copy the full SHA
    fb23da4 View commit details
    Browse the repository at this point in the history

  2. amcheck: brin_index_check() - index structure check 

    Adds a new function brin_index_check() for validating BRIN indexes.
It incudes next checks:
- meta page checks
- revmap pointers is valid and points to index tuples with expected range blkno
- index tuples have expected format
- some special checks for empty_ranges
- every index tuple has corresponding revmap item that points to it (optional)
    @dvcer
    dvcer authored and Commitfest Bot committed Aug 9, 2025
    Configuration menu
    Copy the full SHA
    1938611 View commit details
    Browse the repository at this point in the history

  3. amcheck: common_verify - register snapshot with indcheckxmin check 

    Moves check to common_verify. Every index needs it for heapallindexed check.
    @dvcer
    dvcer authored and Commitfest Bot committed Aug 9, 2025
    Configuration menu
    Copy the full SHA
    db4d177 View commit details
    Browse the repository at this point in the history

  4. amcheck: brin_index_check() - heap all indexed 

    This commit extends functionality of brin_index_check() with
heap_all_indexed check: we validate every index range tuple
against every heap tuple within the range using consistentFn.
Also, we check here that fields 'has_nulls', 'all_nulls' and
'empty_range' are consistent with the range heap data. It's the most
expensive part of the brin_index_check(), so it's optional.
    @dvcer
    dvcer authored and Commitfest Bot committed Aug 9, 2025
    Configuration menu
    Copy the full SHA
    c3ced0d View commit details
    Browse the repository at this point in the history

  5. [CF 5715] v9 - amcheck support for BRIN indexes 

    This branch was automatically generated by a robot using patches from an
email thread registered at:

https://commitfest.postgresql.org/patch/5715

The branch will be overwritten each time a new patch version is posted to
the thread, and also periodically to check for bitrot caused by changes
on the master branch.

Patch(es): https://www.postgresql.org/message-id/CAE7r3MLcV=v-Rr8R1_+aeASSmCprnqw+AEvatKGkKXd2QXhjgQ@mail.gmail.com
Author(s): Arseniy Mukhin
    Commitfest Bot committed Aug 9, 2025
    Configuration menu
    Copy the full SHA
    0f79945 View commit details
    Browse the repository at this point in the history
Loading