Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: postgresql-cfbot/postgresql
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: cf/5520~1
Choose a base ref
...
head repository: postgresql-cfbot/postgresql
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: cf/5520
Choose a head ref
  • 4 commits
  • 11 files changed
  • 4 contributors

Commits on Mar 27, 2025

  1. Rename TRY_POPCNT_FAST to TRY_POPCNT_X86_64. 

    This macro guards x86_64-specific code, and a follow-up commit will
add AArch64-specific versions of that code.  To avoid confusion,
let's rename TRY_POPCNT_FAST to make it more obvious that it's for
x86_64.

Discussion: https://postgr.es/m/010101936e4aaa70-b474ab9e-b9ce-474d-a3ba-a3dc223d295c-000000%40us-west-2.amazonses.com
    @nathan-bossart
    nathan-bossart authored and Commitfest Bot committed Mar 27, 2025
    Configuration menu
    Copy the full SHA
    64f231d View commit details
    Browse the repository at this point in the history

  2. Add Neon popcount support. 

    This commit introduces a Neon implementation of pg_popcount{32,64},
pg_popcount(), and pg_popcount_masked().  As in simd.h, we assume
that all available AArch64 hardware supports Neon, so we
conveniently don't need any new configure-time or runtime checks.
Some compilers emit Neon instructions for these functions already,
but our hand-rolled implementations for pg_popcount() and
pg_popcount_masked() performed better in our tests, presumably due
to the instruction-level parallelism.

Author: "[email protected]" <[email protected]>
Reviewed-by: John Naylor <[email protected]>
Discussion: https://postgr.es/m/010101936e4aaa70-b474ab9e-b9ce-474d-a3ba-a3dc223d295c-000000%40us-west-2.amazonses.com
    @nathan-bossart
    nathan-bossart authored and Commitfest Bot committed Mar 27, 2025
    Configuration menu
    Copy the full SHA
    9a74b1b View commit details
    Browse the repository at this point in the history

  3. Add SVE popcount support. 

    This commit introduces an SVE implementation of pg_popcount{32,64}.
Unlike Neon support, we need an additional configure-time check to
discover whether the compiler supports SVE intrinsics, and we need
a runtime check to find whether the current CPU supports SVE
instructions.  The SVE implementations are much faster for larger
inputs and are comparable to the Neon implementations for smaller
inputs.

Author: "[email protected]" <[email protected]>
Co-authored-by: "Malladi, Rama" <[email protected]>
Co-authored-by: "[email protected]" <[email protected]>
Reviewed-by: Kirill Reshke <[email protected]>
Reviewed-by: John Naylor <[email protected]>
Discussion: https://postgr.es/m/010101936e4aaa70-b474ab9e-b9ce-474d-a3ba-a3dc223d295c-000000%40us-west-2.amazonses.com
Discussion: https://postgr.es/m/OSZPR01MB84990A9A02A3515C6E85A65B8B2A2%40OSZPR01MB8499.jpnprd01.prod.outlook.com
    @nathan-bossart @RamaKishanMalladi @SusmithaDevanga17
    3 people authored and Commitfest Bot committed Mar 27, 2025
    Configuration menu
    Copy the full SHA
    da95bab View commit details
    Browse the repository at this point in the history

  4. [CF 5520] v10 - SVE enablement for pop-count 

    This branch was automatically generated by a robot using patches from an
email thread registered at:

https://commitfest.postgresql.org/patch/5520

The branch will be overwritten each time a new patch version is posted to
the thread, and also periodically to check for bitrot caused by changes
on the master branch.

Patch(es): https://www.postgresql.org/message-id/Z-TIQlPTW1xkpIsN@nathan
Author(s): Chiranmoy Bhattacharya, Susmitha Devanga
    Commitfest Bot committed Mar 27, 2025
    Configuration menu
    Copy the full SHA
    aabfd3b View commit details
    Browse the repository at this point in the history
Loading