Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: postgresql-cfbot/postgresql
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: cf/5151~1
Choose a base ref
...
head repository: postgresql-cfbot/postgresql
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: cf/5151
Choose a head ref
  • 3 commits
  • 11 files changed
  • 2 contributors

Commits on Apr 29, 2025

  1. Add isolation test to reproduce dirty snapshot scan issue 

    This commit introduces an isolation test to reliably reproduce the issue where non-MVCC index scans using SnapshotDirty can miss tuples due to concurrent modifications. This situation can lead to incorrect results.

To facilitate this test, new injection point  added in the index_getnext_slot.

Changes include:

* Added injection point in src/backend/access/index/indexam.c
* Updated Makefile and meson.build to include the new dirty_index_scan isolation test.
* Created a new isolation spec dirty_index_scan.spec and its expected output to define and verify the test steps.
* This test complements the previous fix by demonstrating the issue and verifying that the fix effectively addresses it.
    nkey authored and Commitfest Bot committed Apr 29, 2025
    Configuration menu
    Copy the full SHA
    0fa4195 View commit details
    Browse the repository at this point in the history

  2. Fix btree index scan concurrency issues with dirty snapshots 

    This patch addresses an issue where non-MVCC index scans using SnapshotDirty
or SnapshotSelf could miss tuples due to concurrent modifications. The fix
retains read locks on pages for these special snapshot types until the scan
is done with the page's tuples, preventing concurrent modifications from
causing inconsistent results.

Updated README to document this special case in the btree locking mechanism.
    nkey authored and Commitfest Bot committed Apr 29, 2025
    Configuration menu
    Copy the full SHA
    9b376f1 View commit details
    Browse the repository at this point in the history

  3. [CF 5151] v5 - DirtyScanshot index scan skips concurrently updated tu… 

    …ples

This branch was automatically generated by a robot using patches from an
email thread registered at:

https://commitfest.postgresql.org/patch/5151

The branch will be overwritten each time a new patch version is posted to
the thread, and also periodically to check for bitrot caused by changes
on the master branch.

Patch(es): https://www.postgresql.org/message-id/CADzfLwWuXh8KO=OZvB71pZnQ8nH0NYXfuGbFU6FBiVZUbmuFGg@mail.gmail.com
Author(s): Michail Nikolaev
    Commitfest Bot committed Apr 29, 2025
    Configuration menu
    Copy the full SHA
    26558c2 View commit details
    Browse the repository at this point in the history
Loading