Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: postgresql-cfbot/postgresql
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: cf/4956~1
Choose a base ref
...
head repository: postgresql-cfbot/postgresql
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: cf/4956
Choose a head ref
  • 3 commits
  • 1 file changed
  • 2 contributors

Commits on Apr 4, 2025

  1. Reduce time taken by 002_pg_upgrade test to run 

    This test is one of the longest running tests and
172259a makes it even longer by adding a test
to dump/restore roundtrip of regression database.

The test already creates two clusters for pg_upgrade test. When these clusters
have same version and do not use custom installation, we run dump/restore test.
The new upgraded cluster could be used as target of restore instead of creating
a new cluster.

But this separates the dump and restore phases of the test spatially and
temporaly since the dump needs to be taken while the old cluster is running and
it can be restored only after new upgraded cluster is running; in-between we run
upgrade test. This separation affects readability of the test and hence wasn't
attempted before. But since runtime of test seems to be more important, we take
a hit on readability. We have added additional comments so as to link the two
phases and improve readability.

Author: Ashutosh Bapat <[email protected]>
Reported-by: Andres Freund <[email protected]>
    @ashutosh-bapat
    ashutosh-bapat authored and Commitfest Bot committed Apr 4, 2025
    Configuration menu
    Copy the full SHA
    44b6210 View commit details
    Browse the repository at this point in the history

  2. Turn off log_statement to save CPU cycles 

    The test tests pg_dump and pg_upgrade utilities. Hence logging actual statements
executed on the server is not worth the CPU cycles spent for that. This
is significant in valgrind environment which slows tests down
considerably.

Author: Alvaro Herrera <[email protected]>
Reviewed-by: Ashutosh Bapat <[email protected]>
Suggested-by: Andres Freund <[email protected]>
    @ashutosh-bapat
    ashutosh-bapat authored and Commitfest Bot committed Apr 4, 2025
    Configuration menu
    Copy the full SHA
    a341700 View commit details
    Browse the repository at this point in the history

  3. [CF 4956] Test to dump and restore objects left behind by regression 

    This branch was automatically generated by a robot using patches from an
email thread registered at:

https://commitfest.postgresql.org/patch/4956

The branch will be overwritten each time a new patch version is posted to
the thread, and also periodically to check for bitrot caused by changes
on the master branch.

Patch(es): https://www.postgresql.org/message-id/CAExHW5vX+YLAKsEJT+fvwxmLxGAqDJST+3rqXqeUTjra29x2mA@mail.gmail.com
Author(s): Ashutosh Bapat
    Commitfest Bot committed Apr 4, 2025
    Configuration menu
    Copy the full SHA
    9ccec4d View commit details
    Browse the repository at this point in the history
Loading