Skip to content

Bugfix/issue 38 #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 11, 2021
Merged

Bugfix/issue 38 #39

merged 2 commits into from
Feb 11, 2021

Conversation

ziva777
Copy link
Contributor

@ziva777 ziva777 commented Feb 4, 2021

No description provided.

Copy link
Contributor

@ololobus ololobus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would remove this redundancy comment, otherwise it LGTM

pg_variables.c Outdated
/* Nothing to do here if trans object was removed already. */
if (dlist_is_empty(&object->states))
{
/* Probably redundant. */
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is it redundant?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I can see, the only way we can get here is if variable is already removed. So all the tests are ok just with return here.

@ziva777 ziva777 merged commit d965593 into master Feb 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants