Skip to content

Bugfix/issue 27 #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Oct 30, 2020
Merged

Bugfix/issue 27 #29

merged 12 commits into from
Oct 30, 2020

Conversation

ziva777
Copy link
Contributor

@ziva777 ziva777 commented Oct 29, 2020

No description provided.

@ziva777 ziva777 requested a review from ololobus October 29, 2020 13:40
@codecov
Copy link

codecov bot commented Oct 29, 2020

Codecov Report

Merging #29 into master will increase coverage by 0.34%.
The diff coverage is 98.73%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #29      +/-   ##
==========================================
+ Coverage   96.41%   96.76%   +0.34%     
==========================================
  Files           4        5       +1     
  Lines         921      988      +67     
==========================================
+ Hits          888      956      +68     
+ Misses         33       32       -1     
Impacted Files Coverage Δ
pg_variables.c 97.41% <98.73%> (+0.35%) ⬆️
pg_bin/include/postgresql/server/nodes/pg_list.h 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a135604...20f4ef3. Read the comment docs.

Copy link
Contributor

@ololobus ololobus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All changes look reasonable to me, although I thought it will be easier to implement :( The only doubt I have is that how safe it is, but from the first sight it looks sane

@ololobus ololobus merged commit 080cb1c into master Oct 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants