Skip to content

metadata corruption #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gsmolk opened this issue Oct 14, 2019 · 1 comment
Closed

metadata corruption #132

gsmolk opened this issue Oct 14, 2019 · 1 comment
Labels
bug

Comments

@gsmolk
Copy link
Contributor

gsmolk commented Oct 14, 2019 •
edited
Loading

Introduced by: 66a1c64
Reported by: Leonid Kraubner
If backup_content.control file size is taking more than BLCKSZ*500 (usually 4000KB), then current line will not be added to backup_content.control file.
So we basically loose metadata about one file per 4000KB.
It means that all backups with lots of files taken by 2.1.4, 2.1.5 and 2.2.1 versions are corrupted.

What to do?

  1. Upgrade as soon as you can to 2.2.3 version or newer and make new backups.
  2. Run validate using fresh binary on all backups, it is capable of detecting metadata corruption introduced by this bug.

What to do if metadata corruption is detected?

  1. It is still possible to restore CORRUPT backup to evaluate the situation using --force flag. Restored instance can be verified using checkdb command with --amcheck flag.
  2. Tool for metadata synchronization will be provided shortly
@gsmolk gsmolk added the bug label Oct 14, 2019
gsmolk added a commit that referenced this issue Oct 14, 2019
@gsmolk
[Issue #132] test coverage
4d61a62
@gsmolk gsmolk changed the title losing files in write_backup_filelist() metadata corruption Oct 14, 2019
gsmolk added a commit that referenced this issue Oct 15, 2019
@gsmolk
[Issue #132] fix
251fc83
gsmolk added a commit that referenced this issue Oct 15, 2019
@gsmolk
[Issue #132] validate is now capable of detecting metadata corruption…
f49c197 
… produced by #132
gsmolk added a commit that referenced this issue Oct 15, 2019
@gsmolk
[Issue #132] new flag "--force" for "restore" command allows to ignor…
74e6a5f 
…e invalid backup status during restore
@gsmolk
Copy link
Contributor Author

gsmolk commented Oct 15, 2019 •
edited
Loading

Fixed in 251fc83
Release: 2.2.3

@gsmolk gsmolk closed this as completed Oct 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gsmolk