Skip to content

[ci] Upgrade regression tester projects #3640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 23, 2021

Conversation

adangel
Copy link
Member

@adangel adangel commented Nov 19, 2021

@adangel adangel added the in:pmd-internals Affects PMD's internals label Nov 19, 2021
@ghost
Copy link

ghost commented Nov 19, 2021

1 Message
📖 This changeset changes 127361 violations,
introduces 304495 new violations, 32 new errors and 0 new configuration errors,
removes 174246 violations, 7 errors and 0 configuration errors.
Full report
No java rules are changed!

Generated by 🚫 Danger

@oowekyala
Copy link
Member

Thanks! I think this should be merged. The regression report looks good, it seems some rules that previously had no violations get some coverage now. I found #3642 among the new errors but haven't looked at them all to be honest

@adangel
Copy link
Member Author

adangel commented Nov 23, 2021

I've collected the remaining error in #3643 - I've only looked at the compilable sources. E.g. not the non-compilable - but it seems, that sometimes only the eclipse compiler shows an error, e.g. https://github.com/checkstyle/checkstyle/blob/checkstyle-9.1/src/test/resources-noncompilable/com/puppycrawl/tools/checkstyle/grammar/antlr4/InputAntlr4AstRegressionQualifiedConstructorParameter.java

I'll merge this now into master, so that we have a working build again (hopefully). This will create a new baseline for future pull requests.

@adangel adangel added this to the 6.41.0 milestone Nov 23, 2021
adangel added a commit to adangel/pmd that referenced this pull request Nov 23, 2021
adangel added a commit that referenced this pull request Nov 23, 2021
[ci] Upgrade regression tester projects #3640

* pr-3640:
  [doc] Update release notes (#3635, #3640)
  Revert "Whitespace change to trigger full ci build (incl. regression tests)"
  Whitespace change to trigger full ci build (incl. regression tests)
  [ci] Start with an empty cache
  [ci] Upgrade spring-framework test project to v5.3.13
  [ci] Upgrade checkstyle test project to version 9.1
@adangel adangel merged commit 2004638 into pmd:master Nov 23, 2021
@adangel adangel deleted the issue-3635-regression-projects branch November 25, 2021 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in:pmd-internals Affects PMD's internals
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ci] Update sample projects for regression tester
2 participants