Skip to content

Upgrade vaimo/composer-patches #2304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

herndlm
Copy link
Contributor

@herndlm herndlm commented Mar 26, 2023

was tried already in #1647 and #2129 but I forgot what the problem was..
I hope CI tells me and this time I'll properly note it down

@ondrejmirtes
Copy link
Member

There's also a different library (check what Rector is using), maybe we could switch.

@herndlm herndlm force-pushed the upgrade-composer-patches branch 2 times, most recently from 04b57a4 to 81ecd10 Compare March 26, 2023 19:16
@herndlm
Copy link
Contributor Author

herndlm commented Mar 26, 2023

ah ok, I guess the problem is that vaimo/composer-patches dropped the dependency of drupol/phposinfo which was replaced with loophp/phposinfo and the latest version there is not compatible with PHP 7.2.
using an older version of loophp/phposinfo that is (e.g. 1.6.5) still uses the drupol namespace which breaks vaimo/composer-patches.

so effectively vaimo/composer-patches needs loophp/phposinfo in ^1.7 which is not compatible with PHP 7.2.

@herndlm herndlm force-pushed the upgrade-composer-patches branch 2 times, most recently from b5d2ee5 to a4365dc Compare March 27, 2023 18:26
@herndlm
Copy link
Contributor Author

herndlm commented Mar 27, 2023

hmm close, it would be possible to make this work I guess, but it looks like it involves more github actions / composer install adaptions / hacks. I'll check out the other lib too.

@herndlm herndlm force-pushed the upgrade-composer-patches branch from a4365dc to 696990e Compare April 5, 2023 08:48
@ondrejmirtes
Copy link
Member

cweagans/composer-patches was merged

@herndlm herndlm deleted the upgrade-composer-patches branch April 5, 2023 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants