max()/min() should expect non-empty-array

Author: staabm

resources/functionMap_bleedingEdge.php

@@ -2,7 +2,8 @@
 
 return [
 	'new' => [
-
+		'max' => ['', '...arg1'=>'non-empty-array'],
+		'min' => ['', '...arg1'=>'non-empty-array'],
 	],
 	'old' => [
 

tests/PHPStan/Analyser/NodeScopeResolverTest.php

@@ -1190,6 +1190,12 @@ public function dataFileAsserts(): iterable
 		yield from $this->gatherAssertTypes(__DIR__ . '/../Rules/DeadCode/data/bug-8620.php');
 		yield from $this->gatherAssertTypes(__DIR__ . '/data/bug-8635.php');
 		yield from $this->gatherAssertTypes(__DIR__ . '/data/bug-8625.php');
+		if (PHP_VERSION_ID >= 80000) {
+			yield from $this->gatherAssertTypes(__DIR__ . '/data/bug-7239-php8.php');
+		}
+		if (PHP_VERSION_ID < 80000) {
+			yield from $this->gatherAssertTypes(__DIR__ . '/data/bug-7239.php');
+		}
 		yield from $this->gatherAssertTypes(__DIR__ . '/data/bug-8621.php');
 		yield from $this->gatherAssertTypes(__DIR__ . '/data/bug-8084.php');
 		yield from $this->gatherAssertTypes(__DIR__ . '/data/bug-3019.php');

tests/PHPStan/Analyser/data/bug-7239-php8.php

@@ -0,0 +1,36 @@
+<?php declare(strict_types = 1);
+
+namespace Bug7239php8;
+
+use function PHPStan\Testing\assertType;
+
+class HelloWorld
+{
+	/**
+	 * @param string[] $strings
+	 */
+	public function sayHello(array $arr, $strings): void
+	{
+		assertType('*ERROR*', max([]));
+		assertType('*ERROR*', min([]));
+
+		if (count($arr) > 0) {
+			assertType('mixed', max($arr));
+			assertType('mixed', min($arr));
+		} else {
+			assertType('*ERROR*', max($arr));
+			assertType('*ERROR*', min($arr));
+		}
+
+		assertType('array', max([], $arr));
+		assertType('array', min([], $arr));
+
+		if (count($strings) > 0) {
+			assertType('string', max($strings));
+			assertType('string', min($strings));
+		} else {
+			assertType('*ERROR*', max($strings));
+			assertType('*ERROR*', min($strings));
+		}
+	}
+}

tests/PHPStan/Analyser/data/bug-7239.php

@@ -0,0 +1,36 @@
+<?php declare(strict_types = 1);
+
+namespace Bug7239;
+
+use function PHPStan\Testing\assertType;
+
+class HelloWorld
+{
+	/**
+	 * @param string[] $strings
+	 */
+	public function sayHello(array $arr, $strings): void
+	{
+		assertType('false', max([]));
+		assertType('false', min([]));
+
+		if (count($arr) > 0) {
+			assertType('mixed', max($arr));
+			assertType('mixed', min($arr));
+		} else {
+			assertType('false', max($arr));
+			assertType('false', min($arr));
+		}
+
+		assertType('array', max([], $arr));
+		assertType('array', min([], $arr));
+
+		if (count($strings) > 0) {
+			assertType('string', max($strings));
+			assertType('string', min($strings));
+		} else {
+			assertType('false', max($strings));
+			assertType('false', min($strings));
+		}
+	}
+}

tests/PHPStan/Rules/Functions/CallToFunctionParametersRuleTest.php

@@ -1258,4 +1258,41 @@ public function testBug5986(): void
 		]);
 	}
 
+	public function testBug7239(): void
+	{
+		$tipText = 'array{} is empty.';
+		$this->analyse([__DIR__ . '/../../Analyser/data/bug-7239.php'], [
+			[
+				'Parameter #1 ...$arg1 of function max expects non-empty-array, array{} given.',
+				14,
+				$tipText,
+			],
+			[
+				'Parameter #1 ...$arg1 of function min expects non-empty-array, array{} given.',
+				15,
+				$tipText,
+			],
+			[
+				'Parameter #1 ...$arg1 of function max expects non-empty-array, array{} given.',
+				21,
+				$tipText,
+			],
+			[
+				'Parameter #1 ...$arg1 of function min expects non-empty-array, array{} given.',
+				22,
+				$tipText,
+			],
+			[
+				'Parameter #1 ...$arg1 of function max expects non-empty-array, array{} given.',
+				32,
+				$tipText,
+			],
+			[
+				'Parameter #1 ...$arg1 of function min expects non-empty-array, array{} given.',
+				33,
+				$tipText,
+			],
+		]);
+	}
+
 }