Push Statement::parse() down to SelectStatement #546
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #546 +/- ##
============================================
- Coverage 96.55% 96.33% -0.22%
- Complexity 2166 2174 +8
============================================
Files 87 86 -1
Lines 5025 5051 +26
============================================
+ Hits 4852 4866 +14
- Misses 173 185 +12 ☔ View full report in Codecov by Sentry. |
|
Is there anything we can do about all the PHPStan warnings? |
williamdes
approved these changes
Mar 6, 2024
|
Can you rebase merge this ? |
This removes SelectStatement specific code from Statement::parse() method. Signed-off-by: Maurício Meneghini Fauth <[email protected]>
99e20df to
7f61f31
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes SelectStatement specific code from Statement::parse() method.