Skip to content

Add support for passing integers to Context::setMode #370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 15, 2022

Conversation

MauricioFauth
Copy link
Member

I'm not confident about extracting the SQL mode constants from the Context class (#369), so I just improved the constants documentation blocks and I also added support for passing a combination of Context::SQL_MODE* constants to the Context::setMode method.

Closes #369

@codecov
Copy link

codecov bot commented Jan 14, 2022

Codecov Report

Merging #370 (504f8fb) into master (9cf3396) will increase coverage by 0.15%.
The diff coverage is 94.87%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #370      +/-   ##
============================================
+ Coverage     95.41%   95.57%   +0.15%     
- Complexity     2059     2094      +35     
============================================
  Files            67       67              
  Lines          4410     4478      +68     
============================================
+ Hits           4208     4280      +72     
+ Misses          202      198       -4     
Impacted Files Coverage Δ
src/Tools/TestGenerator.php 0.00% <0.00%> (ø)
src/Utils/CLI.php 97.65% <0.00%> (ø)
src/Context.php 98.31% <100.00%> (+4.67%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9cf3396...504f8fb. Read the comment docs.

@MauricioFauth MauricioFauth self-assigned this Jan 14, 2022
@MauricioFauth MauricioFauth added this to the 5.6.0 milestone Jan 14, 2022
@MauricioFauth MauricioFauth merged commit 41fc6b5 into phpmyadmin:master Jan 15, 2022
@MauricioFauth MauricioFauth deleted the context-sql-modes branch January 15, 2022 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants