Skip to content

Add SqlModes class with SQL modes constants #369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

MauricioFauth
Copy link
Member

  • Creates the PhpMyAdmin\SqlParser\SqlModes class with the Context::SQL_MODE_* constants.
  • Deprecates the Context::SQL_MODE_* constants.

I'm not sure if this is a good thing since an SQL mode can be different depending on the context.

Signed-off-by: Maurício Meneghini Fauth <[email protected]>
@codecov
Copy link

codecov bot commented Jan 9, 2022

Codecov Report

Merging #369 (d22606b) into master (9cf3396) will increase coverage by 0.07%.
The diff coverage is 85.71%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #369      +/-   ##
============================================
+ Coverage     95.41%   95.48%   +0.07%     
- Complexity     2059     2060       +1     
============================================
  Files            67       67              
  Lines          4410     4412       +2     
============================================
+ Hits           4208     4213       +5     
+ Misses          202      199       -3     
Impacted Files Coverage Δ
src/Context.php 96.42% <85.71%> (+2.79%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9cf3396...d22606b. Read the comment docs.

Copy link
Member

@williamdes williamdes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if this is a good thing since an SQL mode can be different depending on the context.

I am not sure to understand

@MauricioFauth
Copy link
Member Author

I'm not sure if this is a good thing since an SQL mode can be different depending on the context.

I am not sure to understand

Some MySQL/MariaDB's SQL modes differ depending on the version. This differences are not handled by sql-parser. I'm not sure if this is relevant or not to sql-parser.

@williamdes
Copy link
Member

I'm not sure if this is a good thing since an SQL mode can be different depending on the context.

I am not sure to understand

Some MySQL/MariaDB's SQL modes differ depending on the version. This differences are not handled by sql-parser. I'm not sure if this is relevant or not to sql-parser.

Maybe relevant, but for now we just store and handle the declared modes so nothing more to do I think

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants