Add phpbench #352
Merged
Add phpbench #352
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
williamdes
added a commit
that referenced
this pull request
Oct 14, 2021
Signed-off-by: William Desportes <[email protected]>
williamdes
added a commit
that referenced
this pull request
Oct 14, 2021
Signed-off-by: William Desportes <[email protected]>
|
@MauricioFauth I pushed the enhancement onto the master branch (79d5db8) as I prefer to sort this PHP 7.2 required thing another time when I have more time |
Signed-off-by: William Desportes <[email protected]>
Signed-off-by: William Desportes <[email protected]>
Signed-off-by: William Desportes <[email protected]>
Signed-off-by: William Desportes <[email protected]>
Codecov ReportBase: 97.25% // Head: 97.25% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #352 +/- ##
=========================================
Coverage 97.25% 97.25%
Complexity 2192 2192
=========================================
Files 68 68
Lines 5055 5055
=========================================
Hits 4916 4916
Misses 139 139 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
I think we can drop PHP 7.1 @MauricioFauth ? |
Yep! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Todo
composer phpbench/phpbench requires php 7.2