Skip to content

Update docs with --EXTENSIONS-- information #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cmb69 merged 1 commit into from
Aug 3, 2021
Merged

Update docs with --EXTENSIONS-- information #34

cmb69 merged 1 commit into from
Aug 3, 2021

Conversation

@MaxSem
Copy link
Contributor

@MaxSem MaxSem commented Apr 18, 2021

No description provided.

@MaxSem MaxSem mentioned this pull request Apr 18, 2021
Closed
cmb69
cmb69 reviewed Apr 19, 2021
View reviewed changes
@MaxSem MaxSem requested a review from cmb69 April 22, 2021 09:09
cmb69
cmb69 approved these changes Apr 22, 2021
View reviewed changes
Copy link
Member

@cmb69 cmb69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I see. Makes sense.

@maaarghk maaarghk mentioned this pull request Apr 25, 2021
Closed
@MaxSem MaxSem mentioned this pull request Aug 1, 2021
Closed
@MaxSem
Copy link
Contributor Author

MaxSem commented Aug 1, 2021

Can someone merge this, please? :)

@cmb69 cmb69 merged commit 7053f7a into php:master Aug 3, 2021
@cmb69
Copy link
Member

cmb69 commented Aug 3, 2021

I have merged this PR now. We need to update phpt_details.php as well, and there it should be made clear that --EXTENSIONS-- is only available as of PHP 8.1.0, and that for versions prior to that respective --SKIPIF-- clauses need to be used instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cmb69 cmb69 cmb69 approved these changes

+1 more reviewer

@carusogabriel carusogabriel carusogabriel approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MaxSem @cmb69 @carusogabriel