-
Notifications
You must be signed in to change notification settings - Fork 7.8k
Prevent fiber switching in tick function and signal handlers #9028
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
fe2d525
to
6baf543
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
However, it is my opinion that support for fiber switching is not really necessary in these contexts.
I concur.
So, please update the docs too. I have a suggestion:
That's sad, really sad. |
@Alimadadi feel free to invest your own free time to investigate the bug (or your own money to contract someone doing it for you) and propose a proper solution - instead of judging about other people, investing their own free time to investigate your bugs. it seems as of now, you are the only one having a use-case for fibers and tick functions in combination. |
@staabm No judge here at all. |
Switching fibers in these contexts causes unexpected consequences:
This PR prevents fiber switching in either context. It is possible in the future ticks or signal handling may be modified to be re-entrant, allowing multiple fibers to enter the handler function. Preventing fiber switching gives us greater freedom to define switching behavior in the future should we decide to properly support switching fibers. However, it is my opinion that support for fiber switching is not really necessary in these contexts.