fix for GH-8157, activate sapi module before POST handling to allow to apply user.ini #8955
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @bukka |
|
From a relatively quick look I'm not sure if this is actually safe as some SAPI's (there are also out of tree external SAPI's so this is an external API) might rely on some of the request_info fields (e.g. request_body, post_entry or cookie_data) to be set before activating which this changes. I will need to look properly which I might do sometime after the feature freeze. |
|
There has not been any recent activity in this PR. It will automatically be closed in 7 days if no further action is taken. |
|
This is a pretty annoying bug with PHP-FPM 😢 AFAIK docs (still) do say that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.