Fix GH-8750: Can not create VT_ERROR variant type #8840
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Despite the current documentation claiming that `variant::__construct()` would allow to create `VT_ERROR` variants, that is not possible. It is not even clear whether this would be desirable, so we introduce `variant::createError()` which explicitly allows to do this. We also introduce `DISP_E_PARAMNOTFOUND` which might be the most important `scode` for this purpose, since this allows to skip optional parameters in method calls.
|
Closing in favor of PR #8886. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Despite the current documentation claiming that
variant::__construct()would allow to create
VT_ERRORvariants, that is not possible. It isnot even clear whether this would be desirable, so we introduce
variant::createError()which explicitly allows to do this.We also introduce
DISP_E_PARAMNOTFOUNDwhich might be the mostimportant
scodefor this purpose, since this allows to skip optionalparameters in method calls.