Disable zend_rc_debug during dl() #8552
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Newly added dl() tests trigger an assertion in ZEND_RC_DEBUG builds. This change disables zend_rc_debug to allows these tests to pass until this issue is resolved.
arnaud-lb
added a commit
to arnaud-lb/php-src
that referenced
this pull request
May 22, 2022
Newly added dl() tests trigger an assertion in ZEND_RC_DEBUG builds. This change disables zend_rc_debug to allows these tests to pass until this issue is resolved. See phpGH-8552
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Newly added dl() tests fail because of an assertion failure in ZEND_RC_DEBUG builds. This change disables zend_rc_debug during dl() to allows these tests to pass.
This is not a regression, hence the "fix".
The issue is that we assert that we do not create persistent interned strings during request, which I believe would indicate a bug and would not be thread safe. But, as acknowledged by the comments above the assertions, this can still happen during dl(). I'm not sure whether this is safe or not, although it may be as long as dl() is not enabled in threaded SAPIs.