Fix TSRM ignoring done #7625
Closed
Fix TSRM ignoring done #7625
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This does correct a couple of inconsistencies in code, and one potential error, but doesn't fix the bug reported because the bug seemed to be caused by misuse. Namely, mixing INIT_MODULE_GLOBALS in a module that uses globals at the module structure level seem incompatible, that results in the allocation of two distinct sets of globals which is probably not the intention. It doesn't look easy to detect this mistake. |
cmb69
approved these changes
Jan 10, 2022
Comment on lines
+191
to
+192
| if (resource_types_table) { | ||
| if (!resource_types_table[j].done) { |
There was a problem hiding this comment.
Might combine these into a single if clause.
|
Merged as d7db5f6 Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I guess a bug will appear for this, reported in r11.