Skip to content

Use zend_string_equals() API instead of strcmp() #6784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 7 commits into from
Closed

Use zend_string_equals() API instead of strcmp() #6784

wants to merge 7 commits into from

Conversation

Girgias
Copy link
Member

@Girgias Girgias commented Mar 17, 2021

Mostly a CI sanity check, but a pair of eyeballs is also appreciated.

@Girgias Girgias force-pushed the refactor-strcmp-usage branch from 4f7b1f2 to 2c90eec Compare March 17, 2021 13:10
nikic
nikic approved these changes Mar 17, 2021
View reviewed changes
Copy link
Member

@nikic nikic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me

@php-pulls php-pulls closed this in a6fc427 Mar 17, 2021
@Girgias Girgias deleted the refactor-strcmp-usage branch March 17, 2021 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikic nikic nikic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Girgias @nikic