Move optimizer into core #6642
Closed
Move optimizer into core #6642
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dstogov Any concerns with moving the optimizer into core? |
This only moves the files, adjusts the build system, exports APIs and does minor fixups to make sure the code builds. This does not yet try to make the optimizer usable independent of opcache.
|
This doesn't work for me. I build PHP in a separate directory. Build fails with "mkdir: cannot create directory 'Zend/Optimizer/.libs': No such file or directory", because "Zend/Optimizer" is missing. I don't object in general. |
|
@nikic I am looking into https://bugs.php.net/bug.php?id=81041 bug. there is comment, citing:
What opcache really does in PHP? Does it do any optimization (outside caching parsed files) and does the optimizations depend on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This only moves the files, adjusts the build system, exports APIs and does minor fixups to make sure the code builds.
This does not yet try to make the optimizer usable independent of opcache.