Make ReflectionUnionType final

[kocsismate]

In spite of the fact that ReflectionNamedType is a non-final class, we can still decide about ReflectionUnionType.

Furthermore, we could also add ZEND_ACC_NO_DYNAMIC_PROPERTIES to ReflectionAttribute, if it's really desirable.

[ondrejmirtes]

No, please don't :( This makes creating an adapter class impossible. The use-case: https://github.com/ondrejmirtes/BetterReflection/blob/master/src/Reflection/Adapter/ReflectionUnionType.php (providing your own reflection implementation and making it compatible with the built-in PHP one).

[nikic]

Okay, let's revert this, it's not important given how most of reflection is non-final. I'm very disappointed in @Ocramius though, he really should know better than using inheritance ;)

[kocsismate]

@nikic I can revert it during the course of the day!

[kocsismate]

Oh, I see that it's too late :) Thanks for the revert!

[ondrejmirtes]

I need to stop reading emails when I wake up in the middle of the night - had a little crisis there :)

These adapters are really useful for PHPStan - it means that I can use the runtime and the static reflection interchangeably. Classes that are safe to autoload use runtime reflection, and everything else uses static reflection.

Thank you both!

[Ocramius]

BTW, if you want to make it final you certainly can, as long as there is an extraction to an interface :D

[ondrejmirtes]

@nikic @kocsismate I just found out that ReflectionAttribute is final :( I'd need it not final for the same reason I need ReflectionUnionType non-final. https://3v4l.org/lfRSE