Skip to content

Fix bug #54379 PDO_OCI: UTF-8 output gets truncated #542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Fix bug #54379 PDO_OCI: UTF-8 output gets truncated #542

wants to merge 1 commit into from

Conversation

gureedo
Copy link

@gureedo gureedo commented Dec 11, 2013

Oracle docs defines three versions of utf8 encoding.

@ghost
Copy link

ghost commented Mar 7, 2015

Can one of the admins verify this patch?

@krakjoe
Copy link
Member

krakjoe commented Jan 4, 2017

The reason nobody has moved on this is because the PR hasn't created a good discussion, what we need is people intimately familiar with this code to review the patch.

What I suggest is that you start a discussion on internals, this should draw out some commentators and help to build a consensus that this is a good solution.

Sorry it has taken so long :)

PS. this needs a reabse

@gureedo
Copy link
Author

gureedo commented Jan 4, 2017

I've deleted my fork about a year ago. Now I forked php-src again, then created branch with the same name, committed patch amd pushed it, but github won't update this PR. Do I need to close this PR and open new one?

@krakjoe
Copy link
Member

krakjoe commented Jan 4, 2017

@gureedo please do create a fresh PR, closing this one for you :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants