Skip to content

Do not include the same stub multiple times #5322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

kocsismate
Copy link
Member

This is a prerequisite for #5195

I haven't done all the changes for intl. But if the current approach is suitable, then I'll continue :)

@kocsismate kocsismate force-pushed the separate-stubs branch 3 times, most recently from fd774e7 to 2a9e444 Compare March 29, 2020 19:22
@nikic
Copy link
Member

nikic commented Apr 2, 2020

Looks basically fine. I'm not entirely happy about the intl part, I'm wondering if we should move all the functions into php_intl.stub.php, as that's where they are registered.

(Generally, I'm not a fan of the over-separation going on in the intl implementation, always opening multiple files until I find where something is defined.)

@kocsismate
Copy link
Member Author

To be honest, I like it very much that the function and method counterparts are close to each other now. Although, the fact that they won't reside in the same file anymore after this PR makes my argument less compelling... So I'm ok to move function stubs to php_intl.stub.php.

@kocsismate
Copy link
Member Author

As a next step, I'll annotate the alias functions.

@php-pulls php-pulls closed this in 305b17e Apr 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants