Clean up remaining opcodes for foreach([] as $x) #4949
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not quite sure what difficulties that would entail, but generally I think that this is something that should be handled by DCE. |
|
Something along these lines: https://gist.github.com/nikic/58d367ad605e10299f5433d2d83a0b5b This doesn't pick up the RESET_RW case due to a weakness in our "may throw" modeling. |
6fc38e7 to
7589192
Compare
Previously, two useless FE_RESET_R and FE_FREE would be left over whether the empty array was from a literal, a variable, or a class constant. This doesn't pick up the RESET_RW case due to a weakness in our "may throw" modeling. (for foreach by reference). Co-Authored-By: Nikita Popov <[email protected]> using https://gist.github.com/nikic/58d367ad605e10299f5433d2d83a0b5b
7589192 to
725bbc7
Compare
nikic
approved these changes
Jan 7, 2021
Girgias
reviewed
Jan 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not familiar with the data structures involved in the passes after dfa,
so I'm not sure how to safely improve on this (removing NOPs).
Two useless FE_RESET_R and FE_FREE would be left over whether the empty array
was from a literal, a variable, or a class constant.