Added Scalar Pseudo-type #2987
Closed
Added Scalar Pseudo-type #2987
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Objects with a magic __toString method are accepted for scalar constrainted types as well if strict mode is not enabled. Overhauled tests and removed redundant test cases.
Didn't check the commits but that is backwards; covariant return types and contravariant parameter types is what is desired. |
|
@morrisonlevi I only mixed the words here in the PR description, the tests use the proper wording and I'll double check the RFC right away: PS: RFC also has it right, limited confusion here; thanks for the heads up. 😉 |
|
Any update on this or has this been abandoned? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for the
scalarpseudo-type with parameter type contravariance and return type covariance to PHP. Please refer to the included tests to see what that means for you as a PHP developer.