Skip to content

fix mbstring extension failed to compile in archlinux system #2722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

fix mbstring extension failed to compile in archlinux system #2722

wants to merge 2 commits into from

Conversation

motecshine
Copy link
Contributor

fix ssize_t is not defined in archlinux

nikic
nikic reviewed Aug 31, 2017
View reviewed changes
ext/mbstring/libmbfl/mbfl/mbfilter.h Outdated
@@ -104,6 +104,8 @@
#define ssize_t __int64
#elif defined(_WIN32)
#define ssize_t __int32
#elif defined(__GNUC__) && __GNUC__ >= 4
#define ssize_t __int128
Copy link
Member

@nikic nikic Aug 31, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty sure __int128 here is not correct. This should be either an int32 or int64 depending on platform, but not int128. As the Windows case is already handled and I think pretty much everything else is LP64 doing #define ssize_t long should do the trick.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will be fix it

@krakjoe
Copy link
Member

krakjoe commented Sep 6, 2017

Merged 9b77615

Thanks.

@krakjoe krakjoe closed this Sep 6, 2017
@nikic
Copy link
Member

nikic commented Sep 6, 2017

@krakjoe Looks like you merged only the first commit.

@motecshine
Copy link
Contributor Author

ping @krakjoe , @nikic is right

@krakjoe
Copy link
Member

krakjoe commented Sep 6, 2017

The files changed view, and the commit seem to match ...

The patch github exports is also matching ...

@motecshine
Copy link
Contributor Author

motecshine commented Sep 6, 2017 •
edited
Loading

How should I do can fix this problem? @krakjoe

image

@krakjoe
Copy link
Member

krakjoe commented Sep 6, 2017

I'm unsure what the problem is: The first commit defined ssize_t as __int128, the second as long ... what exactly is missing ?

@staabm
Copy link
Contributor

staabm commented Sep 6, 2017

long is the expected change ;-)

@krakjoe
Copy link
Member

krakjoe commented Sep 6, 2017

oh I see ... I wonder how that happened ... anyway fixed in c898349

Cheers :)

php-pulls pushed a commit that referenced this pull request Sep 6, 2017
@krakjoe
fixes PR #2722, no clue how it broke ...
c898349
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikic nikic nikic left review comments

Assignees
No one assigned
Labels
Quickfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@motecshine @krakjoe @nikic @staabm