Implement Countable for DomNodeList and DOMNamedNodeMap (Request #74837) #2618

blar · 2017-07-09T00:17:36Z

Implement the Interface Countable for DomNodeList and DOMNamedNodeMap (Request #74837)

$document = new DomDocument();
$root = $document->createElement('root');
$document->appendChild($root);
for($i = 0; $i < 5; $i++) {
    $root->setAttribute('attribute-' . $i, 'value-' . $i);
}
for($i = 0; $i < 7; $i++) {
    $item = $document->createElement('item');
    $root->appendChild($item);
}

// Count childnodes
var_dump(count($root->childNodes));
var_dump($root->childNodes->count());
var_dump($root->childNodes->length);

// Count attributes
var_dump(count($root->attributes));
var_dump($root->attributes->count());
var_dump($root->attributes->length);

Does this require a RFC?

krakjoe · 2017-07-09T06:57:18Z

ext/dom/php_dom.c

@@ -707,6 +707,7 @@ PHP_MINIT_FUNCTION(dom)
 	dom_nodelist_class_entry = zend_register_internal_class_ex(&ce, NULL);
 	dom_nodelist_class_entry->get_iterator = php_dom_get_iterator;
 	zend_class_implements(dom_nodelist_class_entry, 1, zend_ce_traversable);
+	zend_class_implements(dom_nodelist_class_entry, 1, zend_ce_countable);


better to call zend_class_implements once only ...

nikic · 2017-07-09T08:33:34Z

ext/dom/namednodemap.c

+		RETURN_FALSE;
+	}
+
+	RETURN_LONG(count);


Something is not right here. You're returning a zval * as a zend_long here.

What you probably want to do is just pass return_value as the second argument to dom_namednodemap_length_read.

nikic · 2017-07-09T08:35:23Z

ext/dom/namednodemap.c

+	}
+
+	intern = Z_DOMOBJ_P(id);
+	if(dom_namednodemap_length_read(intern, &count)) {


This should compare against SUCCESS or FAILURE.

nikic · 2017-07-09T08:36:19Z

I believe this does not require an RFC. Can we get an opinion from @sgolemon and @remicollet on landing this in 7.2?

remicollet · 2017-07-10T05:51:34Z

I believe this does not require an RFC.

I agree

Can we get an opinion from @sgolemon and @remicollet on landing this in 7.2?

LGTM

remicollet · 2017-07-10T06:51:10Z

Thanks for your contribution.

Squashed and Merged.

blar · 2017-07-17T22:38:40Z

@remicollet May you change my name in the NEWS file from "Andreas Treichel" to "blar"?

Excerpt from the release news: Version 10.37 26-May-2021 ------------------------- A few more bug fixes and tidies. The only change of real note is the removal of the actual POSIX names regcomp etc. from the POSIX wrapper library because these have caused issues for some applications (see 10.33 #2 below). Version 10.36 04-December-2020 ------------------------------ Again, mainly bug fixes and tidies. The only enhancements are the addition of GNU grep's -m (aka --max-count) option to pcre2grep, and also unifying the handling of substitution strings for both -O and callouts in pcre2grep, with the addition of $x{...} and $o{...} to allow for characters whose code points are greater than 255 in Unicode mode. NOTE: there is an outstanding issue with JIT support for MacOS on arm64 hardware. For details, please see Bugzilla issue #2618. Signed-off-by: Anatol Belski <[email protected]>

Implement Countable for DomNodeList and DOMNamedNodeMap (Request #74837)

ab15058

blar mentioned this pull request Jul 9, 2017

Implement Countable for DomNodeList and DOMNamedNodeMap (Request #74837) #2617

Closed

krakjoe reviewed Jul 9, 2017

View reviewed changes

krakjoe added the Feature label Jul 9, 2017

nikic reviewed Jul 9, 2017

View reviewed changes

Implement multiple interfaces at once and remove unnecessary return

46ff960

remicollet closed this Jul 10, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement Countable for DomNodeList and DOMNamedNodeMap (Request #74837) #2618

Implement Countable for DomNodeList and DOMNamedNodeMap (Request #74837) #2618

blar commented Jul 9, 2017

krakjoe Jul 9, 2017

nikic Jul 9, 2017

nikic Jul 9, 2017

nikic Jul 9, 2017

nikic commented Jul 9, 2017

remicollet commented Jul 10, 2017

remicollet commented Jul 10, 2017 •

edited

Loading

blar commented Jul 17, 2017

Implement Countable for DomNodeList and DOMNamedNodeMap (Request #74837) #2618

Implement Countable for DomNodeList and DOMNamedNodeMap (Request #74837) #2618

Conversation

blar commented Jul 9, 2017

krakjoe Jul 9, 2017

Choose a reason for hiding this comment

nikic Jul 9, 2017

Choose a reason for hiding this comment

nikic Jul 9, 2017

Choose a reason for hiding this comment

nikic Jul 9, 2017

Choose a reason for hiding this comment

nikic commented Jul 9, 2017

remicollet commented Jul 10, 2017

remicollet commented Jul 10, 2017 • edited Loading

blar commented Jul 17, 2017

remicollet commented Jul 10, 2017 •

edited

Loading