RFC: UUID (Namespaced) #2547
Closed
RFC: UUID (Namespaced) #2547
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The macro was expanding to a wrong macro and thus leads to compile errors upon usage. Changed it to expand to the correct macro, and added Doxygen documentation to help new users.
Thanks Visual Studio ;(
Thanks Visual Studio ;(
This I did due to a comment by nikic about having them in the header is actually uselus. It required that I move the MINIT function to the bottom of the c file, otherwise the routines are undefined because the compiler cannot find them anymore.
There already is the `zend_parse_parameters_throw` function which does exactly the same thing in a consistent and standard way. This is much, much better. Many thanks to @nikic for pointing that out.
This is now handled by the default PHP implementation. No custom logic means that this is covered by other tests.
Duplicated all type information to ensure compatibility among different PHPDoc implementations. Also reverted `@returns` back to `@return` (this was a typo in an earlier search-replace).
External linking does not seem to make much sense for constant values.
There is not need to allocate the namespace and nil for the complete duration of the program, they are used occassionaly only. Also created macros for the named constructors and getting of the current UUID. This makes the code less readable, but much easier to change.
Also removed the macros again and exchanged them with proper functions. They are simply better in every way, and should be properly inlined by the compiler as well anyways.
Closed
Actually generated the documentation to verify that it is in a format that adheres to the rules of Doxygen, and not PhpDoc.
|
I’m withdrawing this PR. The topic about namespaces in core is to complicated and I do not plan on trying to pursue it any further. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the proposed variation of #2535 with both classes in the
PHP\Stdnamespace (the one I personally would prefer, but the namespace if of course a decision of internals and not of me).Please refer to the UUID RFC for more information, and be sure to post any comment directly on #2535 unless they are about the namespace.