[RFC] Allow overriding abstract methods #2531
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you! ❤ |
nikic
reviewed
May 21, 2017
Zend/tests/abstract_inheritance.phpt
Outdated
| <?php | ||
|
|
||
| abstract class A { abstract function bar($x); } | ||
| abstract class B extends A { abstract function bar($x); } |
There was a problem hiding this comment.
Maybe add two more test for the same with the signature being changed (in a compatible manner and an incompatible manner)?
There was a problem hiding this comment.
I've added those as well.
b208f6a to
2613609
Compare
2613609 to
8d3818f
Compare
nikic
approved these changes
May 24, 2017
|
Merged as a5eb57c. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the RFC: https://wiki.php.net/rfc/allow-abstract-function-override
It also closes #63384