Skip to content

Remove (binary) casts from phar stub #2190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

kelunik
Copy link
Member

@kelunik kelunik commented Nov 7, 2016

Even if #2187 doesn't get merged (now), there's no reason to use (binary) as PHP 6 forward compatibility is not a concern anymore.

@kelunik
Copy link
Member Author

kelunik commented Nov 7, 2016

Closing, there's a separate commit in the mentioned PR that is complete: 33dbcea

@kelunik kelunik closed this Nov 7, 2016
@KalleZ
Copy link
Member

KalleZ commented Nov 7, 2016

I think this should be merged as it does not break anything, and it does ease up forward compatibility in whatever direction we take PHP

ccing @dshafik and @krakjoe as this should go into 7.1 if the time allows us, if not then master is sufficient

@kelunik kelunik deleted the phar-binary-7-1 branch November 7, 2016 18:22
@krakjoe
Copy link
Member

krakjoe commented Nov 7, 2016

@kelunik can we have this branch back please ?

I'm happy to merge this one change, it is all that is required to ease forward compat ... we don't need all those test changes to achieve the same thing, I'm more reluctant to commit those.

@kelunik
Copy link
Member Author

kelunik commented Nov 8, 2016

@krakjoe: We need to adjust the tests that check for the length, too. See the linked commit, I think you can just cherry pick that one.

@krakjoe
Copy link
Member

krakjoe commented Nov 8, 2016

Oh I see, got it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants