uri: Fixes to uri serialization #20369
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ndossche
commented
Nov 2, 2025
- Incoming data should never have an INDIRECT element, that would be a violation of the rules wrt the INDIRECT types. Therefore there was never a need to use the _ind variant of the hash table find.
- It doesn't matter now because there are no properties; but the get_properties handler cannot be used in the output of a __serialize call as that would expose INDIRECT elements. To prevent issues in the future, make it an empty array as a placeholder. If in the future properties are added, then this will hard fail instead of silently fail with INDIRECTs.
- Incoming data should never have an INDIRECT element, that would be a violation of the rules wrt the INDIRECT types. Therefore there was never a need to use the _ind variant of the hash table find. - It doesn't matter now because there are no properties; but the get_properties handler cannot be used in the output of a __serialize call as that would expose INDIRECT elements. To prevent issues in the future, make it an empty array as a placeholder. If in the future properties are added, then this will hard fail instead of silently fail with INDIRECTs.
kocsismate
reviewed
Nov 2, 2025
TimWolla
approved these changes
Nov 2, 2025
ndossche
added a commit
that referenced
this pull request
Nov 2, 2025
* PHP-8.5: Fixes to uri serialization (#20369)
ndossche
added a commit
to ndossche/php-src
that referenced
this pull request
Nov 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.