Skip to content

Deprecate ZEND_SIZE_MAX and point to SIZE_MAX directly #19244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Deprecate ZEND_SIZE_MAX and point to SIZE_MAX directly #19244

wants to merge 1 commit into from
+3 −14

Conversation

marc-mabe
Copy link
Contributor

@marc-mabe marc-mabe commented Jul 26, 2025 •
edited
Loading

SIZE_MAX is available on windows as well.
Also, SIZE_MAX is already used all over the place while ZEND_SIZE_MAX was used only once.

@marc-mabe marc-mabe requested review from dstogov and bukka as code owners July 26, 2025 09:03
@dstogov dstogov requested a review from cmb69 August 5, 2025 14:23
@cmb69
Copy link
Member

cmb69 commented Aug 5, 2025

I don't see any problem regarding the availability of SIZE_MAX on Windows, but I'm not sure that removing ZEND_SIZE_MAX is a good idea regarding external extensions. Maybe just keep #define ZEND_SIZE_MAX SIZE_MAX?

@dstogov
Copy link
Member

dstogov commented Aug 5, 2025

I agree with @cmb69

@marc-mabe marc-mabe changed the title Removed ZEND_SIZE_MAX as SIZE_MAX is available on windows already Deprecate ZEND_SIZE_MAX and point to SIZE_MAX directly Aug 28, 2025
@marc-mabe
Copy link
Contributor Author

I don't see any problem regarding the availability of SIZE_MAX on Windows, but I'm not sure that removing ZEND_SIZE_MAX is a good idea regarding external extensions. Maybe just keep #define ZEND_SIZE_MAX SIZE_MAX?

@cmb69 @dstogov Updated and rebased the PR

cmb69
cmb69 approved these changes Aug 28, 2025
View reviewed changes
Copy link
Member

@cmb69 cmb69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Looks good to me now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmb69 cmb69 cmb69 approved these changes

@Girgias Girgias Girgias approved these changes

@dstogov dstogov Awaiting requested review from dstogov dstogov is a code owner

@bukka bukka Awaiting requested review from bukka bukka is a code owner

Assignees
No one assigned
Labels
ABI break Category: Engine Extension: standard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@marc-mabe @cmb69 @dstogov @Girgias