Skip to content

Zend: Make EG(fake_scope) a const zend_class_entry* #19060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 9, 2025
Merged

Zend: Make EG(fake_scope) a const zend_class_entry* #19060

merged 3 commits into from
Jul 9, 2025
+34 −34

Conversation

TimWolla
Copy link
Member

@TimWolla TimWolla commented Jul 7, 2025

No description provided.

@TimWolla TimWolla requested a review from Girgias July 7, 2025 10:48
@TimWolla TimWolla force-pushed the fake-scope-const branch from 99db870 to 6f56869 Compare July 7, 2025 10:59
Girgias
Girgias approved these changes Jul 7, 2025
View reviewed changes
Copy link
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me, is there a motivation beside adding a const qualifier (something I am all for regardless)?

@TimWolla
Copy link
Member Author

TimWolla commented Jul 7, 2025

is there a motivation beside adding a const qualifier

I wanted to make the scope parameter for clone-with const, but couldn't, since EG(fake_scope) wasn't const.

DanielEScherzer
DanielEScherzer approved these changes Jul 7, 2025
View reviewed changes
Copy link
Member

@DanielEScherzer DanielEScherzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay for ext/reflection

@TimWolla TimWolla merged commit b43a7ac into php:master Jul 9, 2025
1 check passed
@TimWolla TimWolla deleted the fake-scope-const branch July 9, 2025 09:55
TimWolla added a commit to TimWolla/php-src that referenced this pull request Jul 17, 2025
@TimWolla
zend_API: Make scope a const zend_class_entry* for `zend_update_p…
01ce860 
…roperty_*()`

Follow-up for php#19060.
@TimWolla TimWolla mentioned this pull request Jul 17, 2025
Merged
TimWolla added a commit that referenced this pull request Jul 17, 2025
@TimWolla
zend_API: Make scope a const zend_class_entry* for `zend_update_p…
78d96e9 
…roperty_*()` (#19156)

Follow-up for #19060.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Girgias Girgias Girgias approved these changes

@DanielEScherzer DanielEScherzer DanielEScherzer approved these changes

@dstogov dstogov Awaiting requested review from dstogov dstogov is a code owner

Assignees
No one assigned
Labels
ABI break Category: Engine Category: Optimizer Extension: reflection
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TimWolla @Girgias @DanielEScherzer