-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Fix reference type confusion and leak in user random engine #18718
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh god. Whether or not a reference is returned is not part of the signature checks?
Functional changes LGTM, some nits regarding the test, since I've taken great care to keep them consistent.
Co-authored-by: Tim Düsterhus <[email protected]>
Co-authored-by: Tim Düsterhus <[email protected]>
It is, but you cannot make a by-ref return function return by-val: https://3v4l.org/2OmEj |
No description provided.