Skip to content

Make array() a function #18613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Make array() a function #18613

wants to merge 1 commit into from

Conversation

TimWolla
Copy link
Member

No description provided.

@iluuu1994 iluuu1994 marked this pull request as ready for review May 21, 2025 15:19
@iluuu1994 iluuu1994 marked this pull request as draft May 21, 2025 15:20
@iluuu1994
Copy link
Member

Sorry, pressed the wrong button. What's the rationale here? I don't understand the benefits here.

@TimWolla
Copy link
Member Author

What's the rationale here? I don't understand the benefits here.

see: https://externals.io/message/127353#127414

TLDR: Allowing to define arrays with unquoted keys using existing syntax.

@mvorisek
Copy link
Contributor

mvorisek commented May 21, 2025 •
edited
Loading

TLDR: Allowing to define arrays with unquoted keys using existing syntax.

Have you considered [a: 'x', b: 5, ...] syntax?

It is not BC, but introducing array() function seems to be a step backward to me, as it is much less readable and keys with spaces are impossible - or will be BC-breaking anyway https://3v4l.org/hOBDb.

@iluuu1994
Copy link
Member

iluuu1994 commented May 22, 2025 •
edited
Loading

I would agree with @mvorisek on this one. We have spent the last decades switching from array() to []. Do we really want to switch back again?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kocsismate kocsismate Awaiting requested review from kocsismate kocsismate is a code owner

@bukka bukka Awaiting requested review from bukka bukka is a code owner

@dstogov dstogov Awaiting requested review from dstogov dstogov will be requested when the pull request is marked ready for review dstogov is a code owner

Assignees
No one assigned
Labels
ABI break Category: Build System Category: Engine Extension: standard Status: Requires RFC
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TimWolla @iluuu1994 @mvorisek