ext/bcmath: Use const qualifiers appropriately
#18284
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nielsdos
approved these changes
Apr 9, 2025
ext/bcmath/bcmath.c
Outdated
| @@ -1019,7 +1019,7 @@ static void bcmath_number_register_class(void) | |||
| } | |||
|
|
|||
| static zend_always_inline void bcmath_number_add_internal( | |||
| bc_num n1, bc_num n2, bc_num *ret, | |||
| const bc_num n1, const bc_num n2, bc_num *ret, | |||
There was a problem hiding this comment.
Note that bc_num is defined as follows: typedef struct bc_struct *bc_num;
Unfortunately, const bc_num won't do what you probably think it does: it doesn't make the pointer const, it just makes the binding of the variable const. If it was written like bc_struct *n1 then n1 would be a const pointer if you added const before it.
There was a problem hiding this comment.
|
bc_num has been restored, I merge it later! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.