Skip to content

Fix GH-9011: Assertion failure with tracing JIT #17042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 4, 2024
Merged

Conversation

dstogov
Copy link
Member

@dstogov dstogov commented Dec 4, 2024

No description provided.

@cmb69
Copy link
Member

cmb69 commented Dec 4, 2024

Zend\tests\traits\bugs\gh13177.phpt now fails with STATUS_BAD_FUNCTION_TABLE; there are quite a couple of these failures when the engine fatals. See #15709 for more details.

@cmb69 cmb69 linked an issue Dec 4, 2024 that may be closed by this pull request
@dstogov
Copy link
Member Author

dstogov commented Dec 4, 2024

Zend\tests\traits\bugs\gh13177.phpt now fails with STATUS_BAD_FUNCTION_TABLE; there are quite a couple of these failures when the engine fatals. See #15709 for more details.

Thanks for pointing. This failure is not directly related to the fix. I'll respond at #15709 comments later.
Do you see problems with this fix? (I'll add a temporary SKIPIF section)

@cmb69
Copy link
Member

cmb69 commented Dec 4, 2024

I see no issues with this patch (although that doesn't mean much, because I barely understand JIT).

@dstogov
Copy link
Member Author

dstogov commented Dec 4, 2024

I see no issues with this patch (although that doesn't mean much, because I barely understand JIT).

This fix adds missing Windows guards. Without this we might call the previously recorded internal function despite the code actually calls another one.

@dstogov dstogov merged commit 5ab2c02 into php:PHP-8.4 Dec 4, 2024
10 checks passed
dstogov added a commit that referenced this pull request Dec 4, 2024
* PHP-8.4:
  Fix GH-9011: Assertion failure with tracing JIT (#17042)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Assertion failure with tracing JIT
2 participants