Skip to content

Fix GH-16149: Null pointer dereference in DOMElement->getAttributeNames() #16155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix GH-16149: Null pointer dereference in DOMElement->getAttributeNames() #16155

wants to merge 1 commit into from

Conversation

nielsdos
Copy link
Member

@nielsdos nielsdos commented Oct 1, 2024

A namespace without a prefix is by definition always the "xmlns" namespace.

@nielsdos
Fix phpGH-16149: Null pointer dereference in DOMElement->getAttribute…
859aafc 
…Names()

A namespace without a prefix is by definition always the "xmlns"
namespace.
@nielsdos nielsdos linked an issue Oct 1, 2024 that may be closed by this pull request
Null pointer dereference in DOMElement -> getAttributeNames() #16149
Closed
Girgias
Girgias approved these changes Oct 1, 2024
View reviewed changes
Copy link
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MSTM

@Girgias
Copy link
Member

Girgias commented Oct 1, 2024

Normal for the 8.3 target?

@nielsdos
Copy link
Member Author

nielsdos commented Oct 1, 2024

Normal for the 8.3 target?

Yes this is the intended target

cmb69
cmb69 approved these changes Oct 1, 2024
View reviewed changes
Copy link
Member

@cmb69 cmb69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@nielsdos nielsdos closed this in 63e1ebe Oct 1, 2024
jorgsowa pushed a commit to jorgsowa/php-src that referenced this pull request Oct 1, 2024
@nielsdos @jorgsowa
Fix phpGH-16149: Null pointer dereference in DOMElement->getAttribute…
8f20abb 
…Names()

A namespace without a prefix is by definition always the "xmlns"
namespace.

Closes phpGH-16155.
jorgsowa pushed a commit to jorgsowa/php-src that referenced this pull request Oct 1, 2024
@nielsdos @jorgsowa
Fix phpGH-16149: Null pointer dereference in DOMElement->getAttribute…
d070bfe 
…Names()

A namespace without a prefix is by definition always the "xmlns"
namespace.

Closes phpGH-16155.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmb69 cmb69 cmb69 approved these changes

@Girgias Girgias Girgias approved these changes

Assignees
No one assigned
Labels
Extension: dom
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Null pointer dereference in DOMElement -> getAttributeNames()
3 participants
@nielsdos @Girgias @cmb69