Skip to content

Remove non-sensical checks from firebird #16114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 29, 2024

Conversation

nielsdos
Copy link
Member

These conditions are always true because they are arrays that are address-taken, i.e. their addresses will never be NULL.

These conditions are always true because they are arrays that are
address-taken, i.e. their addresses will never be NULL.
Copy link
Member

@SakiTakamachi SakiTakamachi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, LGTM :)

@nielsdos nielsdos merged commit e82b3b2 into php:master Sep 29, 2024
9 of 10 checks passed
jorgsowa pushed a commit to jorgsowa/php-src that referenced this pull request Oct 1, 2024
These conditions are always true because they are arrays that are
address-taken, i.e. their addresses will never be NULL.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants