[RFC] Zend: Warn on resource to string conversions #16022
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
561b883 to
e9ead96
Compare
I have questions as to why zval_compare is basically string_compare_function()
e9ead96 to
03133ff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RFC: https://wiki.php.net/rfc/warn-resource-to-string
Notes about internals function that need some sort of overhaul:
zval_compare()to not be a wrapper aroundstring_compare_function()(and/or refactorphp_array_intersectand co)zend_get_callable_name_ex()to returnNULLas failure when passing a nonsensical type as a callableprint_r()to not emit a warning?