Dynamically xfail test cases which fail on CI #15710
Merged
+43
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a stop-gap measure for phpGH-15709 to keep CI green.
dstogov
added a commit
to dstogov/php-src
that referenced
this pull request
Dec 11, 2024
This reverts commit 6d59620.
dstogov
added a commit
that referenced
this pull request
Dec 12, 2024
This is a quick fix for the problem. It'll work while all the JIT-ed functions have the same "fixed stack frame". Unwinder uses hard-coded unwind data for this "fixed stack frame". * Preallocate space for Win64 shadow args * typo * Setup unwinder for JIT functions * Revert "Dynamically xfail test case which fails on CI" This reverts commit 7cc327f. * Revert "Dynamically xfail test case which fails on CI" This reverts commit bdde797. * Revert "Dynamically xfail test cases which fail on CI (GH-15710)" This reverts commit 6d59620. * Remove XFAIL sections * Add hard-coded SEH unwind data for EXITCALL * Fix unwind data * Fix Windows multi-process support * Typo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a stop-gap measure for GH-15709 to keep CI green.