Clean up mysqli tests #15473
Merged
Clean up mysqli tests #15473
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Girgias
approved these changes
Aug 17, 2024
| @@ -78,8 +78,7 @@ mysqli | |||
| if (1 !== ($tmp = mysqli_affected_rows($link))) | |||
| printf("[025] Expecting int/1, got %s/%s\n", gettype($tmp), $tmp); | |||
|
|
|||
| $charsets = array('utf8'); | |||
| foreach ($charsets as $k => $charset) { | |||
| foreach (['utf8'] as $charset) { | |||
There was a problem hiding this comment.
Can't this foreach be eliminated now? Or do you want to do this as a follow-up?
There was a problem hiding this comment.
I didn't want to touch it further. If you'd like to find a way to remove you can do it as a follow-up. The continue statement deterred me from touching this piece of code.
There was a problem hiding this comment.
Makes sense, could use the typical C-ism of having a do-while loop with break statements, but lets leave this for a follow-up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This mostly removes copy-pasta and fixes unnoticed bugs.