Skip to content

RFC: Change GMP bool cast behavior #15151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

SakiTakamachi
Copy link
Member

@SakiTakamachi SakiTakamachi force-pushed the rfc/change_gmp_bool_cast_behavior branch from 7837edd to 00683fb Compare July 29, 2024 11:38
@TimWolla TimWolla added the RFC label Jul 29, 2024
@SakiTakamachi SakiTakamachi force-pushed the rfc/change_gmp_bool_cast_behavior branch from dadac41 to fce8475 Compare July 29, 2024 23:57
@SakiTakamachi SakiTakamachi marked this pull request as ready for review July 30, 2024 00:08
@SakiTakamachi SakiTakamachi requested a review from Girgias July 30, 2024 00:08
@SakiTakamachi
Copy link
Member Author

Since alpha3 has been released, I will change the place of the NEWS description.

Verified

This commit was signed with the committer’s verified signature.
SakiTakamachi Saki Takamachi

Verified

This commit was signed with the committer’s verified signature.
SakiTakamachi Saki Takamachi
@SakiTakamachi SakiTakamachi force-pushed the rfc/change_gmp_bool_cast_behavior branch from 8d834c9 to 6749f2b Compare July 30, 2024 14:51

Verified

This commit was signed with the committer’s verified signature.
SakiTakamachi Saki Takamachi
Co-authored-by: Tim Düsterhus <tim@bastelstu.be>
@SakiTakamachi SakiTakamachi force-pushed the rfc/change_gmp_bool_cast_behavior branch from 9fb3561 to b5dd8ca Compare July 30, 2024 14:55
@SakiTakamachi
Copy link
Member Author

done

Copy link
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SakiTakamachi SakiTakamachi merged commit 60afeb5 into php:master Jul 30, 2024
9 of 11 checks passed
@SakiTakamachi SakiTakamachi deleted the rfc/change_gmp_bool_cast_behavior branch July 30, 2024 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants