-
Notifications
You must be signed in to change notification settings - Fork 7.9k
RFC: Change GMP bool cast behavior #15151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
SakiTakamachi
merged 3 commits into
php:master
from
SakiTakamachi:rfc/change_gmp_bool_cast_behavior
Jul 30, 2024
Merged
RFC: Change GMP bool cast behavior #15151
SakiTakamachi
merged 3 commits into
php:master
from
SakiTakamachi:rfc/change_gmp_bool_cast_behavior
Jul 30, 2024
+25
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7837edd
to
00683fb
Compare
Girgias
reviewed
Jul 29, 2024
dadac41
to
fce8475
Compare
TimWolla
reviewed
Jul 30, 2024
Since alpha3 has been released, I will change the place of the NEWS description. |
Loading status checks…
8d834c9
to
6749f2b
Compare
Loading status checks…
Co-authored-by: Tim Düsterhus <tim@bastelstu.be>
9fb3561
to
b5dd8ca
Compare
done |
Girgias
approved these changes
Jul 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://wiki.php.net/rfc/fix_up_bcmath_number_class