Skip to content

Autotools: Quote all PHP_ADD_BUILD_DIR arguments #14947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
petk merged 1 commit into from
Jul 14, 2024
Merged

Autotools: Quote all PHP_ADD_BUILD_DIR arguments #14947

petk merged 1 commit into from
Jul 14, 2024

Conversation

@petk
Copy link
Member

@petk petk commented Jul 13, 2024

  • All arguments quoted for consistency
  • m4_normalize used where list of directories becomes a bit simpler to read and see the diff

@petk
Autotools: Quote all PHP_ADD_BUILD_DIR arguments
a929bbc 
- All arguments quoted for consistency
- m4_normalize used where list of directories becomes a bit simpler to
  read and see the diff
Girgias
Girgias approved these changes Jul 13, 2024
View reviewed changes
Copy link
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me

@petk petk merged commit 0e2e8e0 into php:master Jul 14, 2024
@petk petk deleted the patch-PHP_ADD_BUILD_DIR-2 branch July 14, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Girgias Girgias Girgias approved these changes

@devnexen devnexen devnexen approved these changes

@ndossche ndossche ndossche approved these changes

@SakiTakamachi SakiTakamachi SakiTakamachi approved these changes

@bukka bukka Awaiting requested review from bukka bukka is a code owner

@dstogov dstogov Awaiting requested review from dstogov dstogov is a code owner

@iluuu1994 iluuu1994 Awaiting requested review from iluuu1994

@alexdowad alexdowad Awaiting requested review from alexdowad alexdowad is a code owner

@youkidearitai youkidearitai Awaiting requested review from youkidearitai youkidearitai is a code owner

@derickr derickr Awaiting requested review from derickr derickr is a code owner

Assignees

No one assigned

Labels

Category: Build System Extension: bcmath Extension: date Extension: dba Extension: dom Extension: fileinfo Extension: gd Extension: hash Extension: intl Extension: mbstring Extension: opcache Extension: pcre Extension: standard SAPI: fpm

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@petk @devnexen @ndossche @Girgias @SakiTakamachi