ext/intl: further fast ZPP usage. #14419
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Girgias
approved these changes
Jun 1, 2024
| Z_PARAM_OBJECT(object) | ||
| Z_PARAM_OPTIONAL | ||
| Z_PARAM_ZVAL(format) | ||
| Z_PARAM_STRING_OR_NULL(locale_str, locale_len) |
There was a problem hiding this comment.
Does it possibly make more sense to use a zend_string here to be able to keep the const qualifier?
There was a problem hiding this comment.
That is a possibility I may look after indeed.
nielsdos
reviewed
Jun 1, 2024
| @@ -82,8 +82,15 @@ U_CFUNC PHP_FUNCTION(datefmt_format_object) | |||
| RETURN_THROWS(); | |||
| } | |||
|
|
|||
| ZEND_PARSE_PARAMETERS_START(1, 3) | |||
There was a problem hiding this comment.
Forgot to remove the zend_parse_parameters in this function.
c45d0e3 to
e733191
Compare
nielsdos
approved these changes
Jun 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.