-
Notifications
You must be signed in to change notification settings - Fork 7.8k
Amend PDO driver-specific class names #14069
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
f519b84
to
0ff7c0b
Compare
If Tim's RFC is passed, the In that case the stub would look like this:
This may not happen due to backward compatibility issues, but I'd like to comment as a memorandum. |
Was there any conclusion in the thread? It would be nice if we could implement these changes. |
I haven't received a response so I'll try emailing again. |
It's been a week since I sent the email, and so far there have been no objections. In my opinion, it's ok to merge this, but should we wait a bit longer? |
0ff7c0b
to
aad9460
Compare
79e242d
to
e022180
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pdo_pgsql looks good
@kocsismate You'll also need to adjust the names in NEWS/UPGRADING. |
@TimWolla Yeah, I know I forgot, but it's going to be fixed soon: #14299 (comment) |
Follow-up to phpGH-14069. Signed-off-by: Ayesh Karunaratne <[email protected]>
As suggested in https://externals.io/message/123166