Skip to content

[RFC] Add stream open functions to XML{Reader,Writer} #14030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 29, 2024
Merged

[RFC] Add stream open functions to XML{Reader,Writer} #14030

merged 3 commits into from
Jun 29, 2024

Conversation

nielsdos
Copy link
Member

@nielsdos nielsdos commented Apr 21, 2024 •
edited
Loading

@nielsdos nielsdos added the RFC label Apr 21, 2024
@nielsdos nielsdos requested a review from kocsismate as a code owner April 21, 2024 17:44
@nielsdos nielsdos force-pushed the xmlwriter-openstream branch 2 times, most recently from b3b3091 to 71de903 Compare April 24, 2024 20:44
@nielsdos nielsdos changed the title [RFC] Add XMLWriter::openStream() and XMLReader::openStream() [RFC] Add stream open functions to XML{Reader,Writer} Jun 25, 2024
@nielsdos nielsdos force-pushed the xmlwriter-openstream branch 3 times, most recently from 5ca4686 to 57c1323 Compare June 27, 2024 21:37
@nielsdos nielsdos requested a review from Girgias June 28, 2024 07:29
Girgias
Girgias approved these changes Jun 29, 2024
View reviewed changes
Copy link
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor questions, but LGTM thank you!

@nielsdos nielsdos force-pushed the xmlwriter-openstream branch from 57c1323 to f5e2869 Compare June 29, 2024 15:12
@nielsdos nielsdos merged commit 4cab7f9 into php:master Jun 29, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Girgias Girgias Girgias approved these changes

@kocsismate kocsismate Awaiting requested review from kocsismate kocsismate is a code owner

Assignees
No one assigned
Labels
Extension: xmlreader Extension: xmlwriter RFC
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nielsdos @Girgias